Force skeptic tests to be located in temporary directory

[budziq]

This is a relatively ugly hack reolving https://github.com/brson/rust-skeptic/issues/23

This should solve problem test artifacts polluting working directory such as https://github.com/brson/rust-cookbook/issues/29

[budziq]

Hi @brson
Is this what you've had in mind in https://github.com/brson/rust-skeptic/issues/23 ?

[brson]

Oh wow! Thanks @budziq. Yeah this is totally the right idea.

This won't quite work correctly as-is because 'set_current_dir` will change the directory for the process globally, and since tests execute concurrently it will cause a race condition.

The way to do this to avoid the race is to pass outdir to the run_test_case function and set current_dir on the Command function that runs the executable. Do you mind trying to make that change and see how it works?

Sorry for not seeing this earlier. Feel free to ping me on IRC or email me if it looks like I'm ignoring your PRs - I mostly don't see GitHub notifications.

[budziq]

Argh! I haven't really thought this through ☹️
Thanks for your suggestions and time! I'll allot some time this week to fix it.

[budziq]

@brson updated according to your suggestions. It works well enough to trigger failures in two examples expecting CWD to be rust-cookbook root 😁.

Two points of note:

• this makes writing tests somewhat less comfortable as skeptic does not provide any way to provide test fixtures (but this can be remedied by hidden test parts written by hand or making them no_run)
• this is a breaking change which will make some peoples CI fail suddenly so I would suggest bumping to 0.10

Also, I was not able to find a way to write a testcase for this behaviour (running test and then checking for its artifact outside of the runner) that would not require big rewrite.

[brson]

It works well enough to trigger failures in two examples

Haha. I don't mind this. Seems appropriate for those test cases to be independent of the cookbook contents anyway.

this is a breaking change which will make some peoples CI fail suddenly so I would suggest bumping to 0.10

I'll bump the version and make a release.

[brson]

I published 0.10.0

[budziq]

Thanks!