Get rlib hash from parent path of json in fingerprint #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
current rust nightly no longer allows extern crates in markdown. This pull request addresses the changes to the compiler internals which removed the hash from the json file's name. |
|
Can confirm, recently all of the nannou guide tests began failing, however switching our skeptic dependency over to this branch resolves our issues. Thanks @AndyGauge! |
mitchmindtree
added a commit
to mitchmindtree/nannou
that referenced
this pull request
Jul 29, 2020
A recent change to cargo has started causing tests generated by `rust-skeptic` to fail. budziq/rust-skeptic#120. This has started causing [issues with our CI](https://github.com/nannou-org/nannou/pull/636/checks?check_run_id=920796725). This PR temporarily switches to a branch with a patch for this issue. We should remove this once budziq/rust-skeptic#121 is merged and published.
|
This is how the rust cookbook is doing it in case anyone else has the need before this is merged: |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120