Merge v1.4.11 dfd33c7 #38
Annotations
1 error and 1 warning
commitlint (14.x, ubuntu-latest)
You have commit messages with errors
⧗ input: core/state: fix SetStorage override behavior (#30185)
⚠ footer must have leading blank line [footer-leading-blank]
⚠ found 0 problems, 1 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
⧗ input: eth/tracers, internal/ethapi: remove unnecessary map pointer in state override (#30094)
✖ header must not be longer than 80 characters, current length is 87 [header-max-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
⧗ input: eth/catalyst: get params.ExcessBlobGas but check with params.BlobGasUsed (#30267)
Seems it is checked with the wrong argument
Signed-off-by: jsvisa <[email protected]>
✖ header must not be longer than 80 characters, current length is 81 [header-max-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
⧗ input: core/vm/runtime: ensure tracer benchmark calls `OnTxStart` (#30257)
The struct-based tracing added in #29189 seems to have caused an issue
with the benchmark `BenchmarkTracerStepVsCallFrame`. On master we see
the following panic:
```console
BenchmarkTracerStepVsCallFrame
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x40 pc=0x1019782f0]
goroutine 37 [running]:
github.com/ethereum/go-ethereum/eth/tracers/js.(*jsTracer).OnOpcode(0x140004c4000, 0x0, 0x10?, 0x989680, 0x1, {0x101ea2298, 0x1400000e258}, {0x1400000e258?, 0x14000155928?, 0x10173020c?}, ...)
/Users/matt/dev/go-ethereum/eth/tracers/js/goja.go:328 +0x140
github.com/ethereum/go-ethereum/core/vm.(*EVMInterpreter).Run(0x14000307da0, 0x140003cc0d0, {0x0, 0x0, 0x0}, 0x0)
...
FAIL github.com/ethereum/go-ethereum/core/vm/runtime 0.420s
FAIL
```
The issue seems to be that `OnOpcode` expects that `OnTxStart` has
already been called to initialize the `env` value in the tracer. The JS
tracer uses it in `OnOpcode` for the `GetRefund()` method.
This patch resolves the issue by reusing the `Call` method already
defined in `runtime_test.go` which correctly calls `OnTxStart`.
✖ footer's lines must not be longer than 100 characters [footer-max-line-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
⧗ input: signer/core: improve performance of isPrimitiveTypeValid function (#30274) (#30277)
Precomputes valid primitive types into a map to use for validation, thus removing sprintf.
✖ header must not be longer than 80 characters, current length is 83 [header-max-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
⧗ input: eth/downloader, core/types: take withdrawals-size into account in downloader queue (#30276)
Fixes a slight miscalculation in the downloader queue, which was not accurately taking block withdrawals into account when calculating the size of the items in the queue
✖ body's lines must not be longer than 100 characters [body-max-line-length]
✖ header must not be longer than 80 characters, current length is 91 [header-max-length]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
⧗ input: cmd/evm: fix evm basefee (#30281)
fixes #30279 -- previously we did not use the basefee from the genesis, and instead the defaults were used from `runtime.go/setDefaults`-function
✖ footer's lines must not be longer than 100 characters [footer-max-line-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
⧗ input: beacon/engine, consensus/beacon: use params.MaximumExtraDataSize instead of hard-coded value (#29721)
Co-authored-by: Felix Lange <[email protected]>
Co-authored-by: Marius van der Wijden <[email protected]>
Co-authored-by: lightclient <[email protected]>
✖ header must not be longer than 80 characters, current leng
|
commitlint (14.x, ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|