Repository navigation
docs(plans): ADR-010 immutable result store, every entry materialized, one owning process (rejected) - #212
Closed
paddymul wants to merge 3 commits into
Closed
docs(plans): ADR-010 immutable result store, every entry materialized, one owning process (rejected)#212paddymul wants to merge 3 commits into
paddymul wants to merge 3 commits into
Conversation
…re name and the GC depth Adds scripts/spike_multiset_digest.py: an order-insensitive digest built on numpy uint64 arithmetic, 4.3s on 18M rows. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Paddy rejected ADR-010 on 2026-09-22: it does not solve the problem comprehensively or simplify the design as much as expected. The status block says so, and a new "Why it was rejected" section records what the review found. The proposal itself is unchanged below it, kept for the record. ADR-007, ADR-008 and ADR-009 stand as written. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
paddymul
marked this pull request as ready for review
September 22, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rejected (2026-09-22). This PR keeps ADR-010 in the repo as a rejected proposal. Paddy rejected it after review: it does not solve the problem comprehensively, and it does not simplify the design as much as expected. The ADR's new "Why it was rejected" section has the findings. In short:
collect/first/unsortedlimit/window ties, and float digests. It also breaksdocs/system-contract.mdI2 and I6.ADR-007, ADR-008 and ADR-009 stand as written. The issues ADR-010 listed as closed stay open.
Original description (the proposal as it stood)
Proposed ADR following the review of #189, which filed #193 to #211. None of those is an xorq bug. They come from row order carried through recipes, result files with a mutable lifecycle, two kinds of entry, and Buckaroo executing expressions.
Decisions, in short:
result_digest. Single-partition execution is retired. Sort ties are broken by sortable columns, not__row_order.__row_order, and recipes never see it. Ordered copies are removed.tallyman gc.TALLYMAN_HOME(a flock held for its lifetime). The MCP server becomes a client.It amends ADR-007/008/009, which are on #184/#189 and not yet on main, so those links resolve once #189 merges. The ADR has a per-decision table of what stands, changes or is retired, and a list of the issues it closes.
🤖 Generated with Claude Code