Fix check_archive_ready for version 10 and above #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbanck
force-pushed
the
check_archive_ready_v10
branch
from
680aa4a
to
264458c
Compare
The archive_ready check uses the wal_files check with dedicated options - however, since wal_files was fixed for version 10 in 8e6b3c2 it called pg_ls_waldir() even for the archive_ready check which is not appropriate as this only lists files in pg_wal and not in pg_wal/archive_status. This change makes the wal_files check call pg_ls_archive_statusdir() instead if $extrabit (i.e. .ready) is set, fixing issue bucardo#150.
mbanck
force-pushed
the
check_archive_ready_v10
branch
from
264458c
to
6d69b98
Compare
|
Ping, any updated on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #150.