ngrok.disconnect not closing http tunnel (only https)

[nojiek]

When two tunnels are opened simultaneously (bind_tls: both (this is default)), ngrok fails to close both tunnels when using the disconnect command.

Steps to Reproduce:

ngrok.connect(bind_tls: 'both', port: currentPort), function((err, url) {
     console.log("Error Message: " + err);
     console.log('Ngrok URL: ' + url);
     console.log('Port: ' + currentPort);
}

Results in:
Error Message: null
Ngrok URL: https://030927d2.ngrok.io
Port: 3599

This opens TWO tunnels: one at http and one at https

//Kills the ngrok tunnel
ngrok.disconnect(killUrl, function () {
    console.log('URL: ' + killUrl + ' has been killed.');
});

Results:
URL: https://030927d2.ngrok.io has been killed.
{ [Error: socket hang up] code: 'ECONNRESET' }

Note that the http tunnel remains open.

[bubenshchykov]

hey @nojiek, great catch! :)

as a possible workaround, you can close all tunnels with ngrok.kill() - it shots down the whole ngrok process.. and you can ngrok.connect after it again

[vinceis1337]

Hello @bubenshchykov - I work with @nojiek and we have a workaround. We just wanted to let you know about the problem. Thanks!

[nojiek]

@bubenshchykov Thanks! Our work around is to just to not use "both" for now.

[bubenshchykov]

fixed and covered by test

ngrok/test/ngrok.guest.spec.js

Line 76 in 125c540

describe('disconnecting from ngrok', function () {

;)

if you create default bind_tls=true tunnel (two tunnels) and get let's say https://123.ngrok.io - then you can

• either close both tunnels in two calls: ngrok.disconnect('https://123.ngrok.io'); ngrok.disconnect('http://123.ngrok.io');
• or close all tunells by ngrok.disconnect(); - it now tracks and closes http tunnel too
• or kill entire process by ngrok.kill();

---

PS what we can also do is to make bind_tls=false by default.. because it's a bit confusing and requires some reading of ngrok docs :) or we can kill both tunnels even if you just ask to kill one ngrok.disconnect('https://123.ngrok.io'); - but that might not be what all devs want

so i'll leave it as it is for now, and see how it goes :)
https://github.com/bubenshchykov/ngrok#disconnect