Culmination of recent voting pool PRs that need to be reviewed. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to store the number of required sigs for a given input as well as the raw signatures themselves.
* ChangeAddress(): error if index==0 * DepositScript(): error if index >= hdkeychain.HardenedKeyStart Also get rid of nextChangeAddress(), which was broken as a given withdrawal should only use change addresses from the active series.
These now include the ID of the highest series that needs to be thawed before the requests can be fulfilled.
davecgh
changed the title
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Oct 4, 2016
This is a step towards completing btcsuite#315. This changes the database access APIs and each of the "manager" packages (waddrmgr/wtxmgr/wstakemgr) so that transactions are opened (only) by the wallet package and the namespace buckets that each manager expects to operate on are passed in as parameters. This helps improve the atomicity situation as it means that many calls to these APIs can be grouped together into a single database transaction. This change does not attempt to completely fix the "half-processed" block problem. Mined transactions are still added to the wallet database under their own database transaction as this is how they are notified by the consensus JSON-RPC server (as loose transactions, without the rest of the block that contains them). It will make updating to a fixed notification model significantly easier, as the same "manager" APIs can still be used, but grouped into a single atomic transaction.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Nov 2, 2016
Save all block headers and ensure that they attach. With all headers saved, the wallet is able to perform more validation checking when attaching blocks to the main chain. This also improves compatibility with SPV, which requires all block headers to be saved. Significantly improve the rescan logic so it is more understandable and reusable, and in the future, cancelable. This also leads the way to add a new RPC to trigger a rescan starting from some block hash or height. Fixes btcsuite#315.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Nov 7, 2016
Save all block headers and ensure that they attach. With all headers saved, the wallet is able to perform more validation checking when attaching blocks to the main chain. This also improves compatibility with SPV, which requires all block headers to be saved. Significantly improve the rescan logic so it is more understandable and reusable, and in the future, cancelable. This also leads the way to add a new RPC to trigger a rescan starting from some block hash or height. Fixes btcsuite#315.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Nov 8, 2016
Save all block headers and ensure that they attach. With all headers saved, the wallet is able to perform more validation checking when attaching blocks to the main chain. This also improves compatibility with SPV, which requires all block headers to be saved. Significantly improve the rescan logic so it is more understandable and reusable, and in the future, cancelable. This also leads the way to add a new RPC to trigger a rescan starting from some block hash or height. This change includes a database upgrade, so it is not possible to use an updated database changed by this commit on older versions of the wallet. Fixes btcsuite#315.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Nov 9, 2016
Save all block headers and ensure that they attach. With all headers saved, the wallet is able to perform more validation checking when attaching blocks to the main chain. This also improves compatibility with SPV, which requires all block headers to be saved. Significantly improve the rescan logic so it is more understandable and reusable, and in the future, cancelable. This also leads the way to add a new RPC to trigger a rescan starting from some block hash or height. This change includes a database upgrade, so it is not possible to use an updated database changed by this commit on older versions of the wallet. Fixes btcsuite#315.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.