Improve account related test coverage

[tuxcanfly]

Added test coverage for account related manager funcs.

[jrick]

Is this field needed? doesn't look used and the address in the p2sh address test is actually a p2pkh addr.

[tuxcanfly]

I'm using this field now, to switch between managedAddress and scriptAddress so that both paths are covered in the test cases.

[jrick]

The type itself is used, but not the data. I would consider using constants here instead:

func testMarkUsed(tc *testContext) bool {
    type addrType byte
    const (
        addrPubKeyHash addrType = iota
        addrScriptHash
    )
    tests := []struct {
        typ addrType
        // ...
    }

    // ...

        switch test.typ {
        case addrPubKeyHash:
            // ...
        case addrScriptHash:
            // ...
        default:
            panic("unreachable")
        }

    // ...
}

[tuxcanfly]

Thanks, updated to use addrType const

[tuxcanfly]

Thanks, removed it.

[jrick]

Please remove tab characters between the // and the comment text.

[tuxcanfly]

Sorry, slipped past my editor, removed.

[jrick]

Unneeded type and iota here

[jrick]

This looks ok now. Can you squash and rebase?

[tuxcanfly]

@jrick Thanks, rebased now.

[davecgh]

OK

[davecgh]

Need rebase to latest master.

[tuxcanfly]

OK, squashed and rebased to latest master.