Integrate wtxmgr #234
Integrate wtxmgr #234
Conversation
jrick
force-pushed
the
jrick_intwtxmgr
branch
2 times, most recently
from
ab4a4c3 to
9f2a560
Compare
jrick
force-pushed
the
jrick_intwtxmgr
branch
4 times, most recently
from
0565215 to
6fe92dc
Compare
|
I'm going to add an extra utility that can be used to drop the wtxmgr namespace. This will allow us to force rescans. I'm hesitant to make this a feature of the rpc server, since this step really should never be necessary (but good idea to add it just in case). |
jrick
force-pushed
the
jrick_intwtxmgr
branch
7 times, most recently
from
21592f7 to
48b93b6
Compare
| // height comes before the begin height, blocks are iterated in reverse order | ||
| // and unmined transactions (if any) are processed first. | ||
| // | ||
| // The function f may return an error which, if non-nil, is propigated to the |
jrick
force-pushed
the
jrick_intwtxmgr
branch
2 times, most recently
from
1dde322 to
7904b21
Compare
|
Rebased over hashing API changes. |
jrick
force-pushed
the
jrick_intwtxmgr
branch
3 times, most recently
from
48d20d6 to
329c16d
Compare
|
Since the new utility isn't using the same flags package as wallet and everything else, it's inconsistent. I think it's important from a usability aspect for everything in the suite to be consistent. Can you change the util over to use go-flags? |
| two situations when this holds true: | ||
|
|
||
| 1. The wallet is newly created or was recreated from the seed | ||
|
|
There was a problem hiding this comment.
I believe markdown formats lists better if there is no newline between the list items.
|
Guide about dropping transactions is a very nice addition. |
|
I can convert the flags over. I just used the stdlib because this is a dev tool that won't see much use, and the entire flags package API fits in my head. |
| @@ -52,7 +52,7 @@ var ( | |||
| var subsystemLoggers = map[string]btclog.Logger{ | |||
| "BTCW": log, | |||
| "WLLT": walletLog, | |||
| "TXST": txstLog, | |||
| "TXST": txmgrLog, | |||
There was a problem hiding this comment.
Not a big deal, but probably should make the prefix match the name. If it's going to be called tx manager now, ideally it would be referred to that throughout. How about "TMGR" or "TXMR"?
|
Everything else reads correctly. I'm going to spend some time testing it, but I'm done with the code review. |
|
Doing some testing and noticed this doesn't remove the old |
|
No harm in leaving it around, and it can always be manually deleted. I'd rather avoid checking for an ancient file each and every startup for the rest of forever to clean up something that maybe a handful of people might have. |
|
Alright, I've tested this pretty well. I've also confirmed the latest commit fixed the issue reported in IRC. I also tested the OK. |
This is intended to be used to force a full rescan.
Depends on #217.mergedThis contains the changes to integrate wtxmgr with the rest of the wallet code and removes the legacy txstore package.