Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listsinceblock transaction format differences to bitcoin core #272

Closed
arnuschky opened this issue May 13, 2015 · 2 comments · Fixed by #274
Closed

listsinceblock transaction format differences to bitcoin core #272

arnuschky opened this issue May 13, 2015 · 2 comments · Fixed by #274

Comments

@arnuschky
Copy link

Back to the worst call of a crappy API. :( Sorry for this...

  1. btcwallet does not list blockindex for transactions in listsinceblock.

  2. btcwallet lists a positive fee for transactions of category send while bitcoin core lists a negative fee.
@jrick
Copy link
Member

jrick commented May 13, 2015

blockindex is no longer tracked. It was dropped from wtxmgr in preparation for SPV support later. We can't report it.

The negative fee is inane but I can switch it.

jrick added a commit to jrick/btcwallet that referenced this issue May 13, 2015
@jrick
Use negative fees with listtransaction result types.
736a46f 
This matches Bitcoin Core Wallet.

Fixes btcsuite#272.
@jrick jrick mentioned this issue May 13, 2015
Merged
@arnuschky
Copy link
Author

Ok, great, thanks. Agree wrt to negative fee.

jrick added a commit to jrick/btcwallet that referenced this issue Jun 14, 2016
@jrick
Add non-internal prompt package.
4c3a64e 
This makes the internal prompt.Setup function available for use in
other projects.

Fixes btcsuite#272.
jrick added a commit to jrick/btcwallet that referenced this issue Jun 14, 2016
@jrick
Add non-internal prompt package.
ff3bb89 
This makes the internal prompt.Setup function available for use in
other projects.

Since this package is not imported by the wallet package, there is no
need to pass the insecure public data encryption passphrase as a
parameter, and instead it can use the wallet constant.

Fixes btcsuite#272.
jrick added a commit to jrick/btcwallet that referenced this issue Jun 14, 2016
@jrick
Add non-internal prompt package.
a487c38 
This makes the internal prompt.Setup function available for use in
other projects.

Since this package is not imported by the wallet package, there is no
need to pass the insecure public data encryption passphrase as a
parameter, and instead it can use the wallet constant.

Fixes btcsuite#272.
jrick added a commit to jrick/btcwallet that referenced this issue Jun 14, 2016
@jrick
Add non-internal prompt package.
dfb6bcd 
This makes the internal prompt.Setup function available for use in
other projects.

Since this package is not imported by the wallet package, there is no
need to pass the insecure public data encryption passphrase as a
parameter, and instead it can use the wallet constant.

Fixes btcsuite#272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use negative fees with listtransaction result types. jrick/btcwallet
2 participants
@arnuschky @jrick