Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: remove listaddresstransactions RPC #231

Open
jrick opened this issue Apr 3, 2015 · 1 comment
Open

Proposal: remove listaddresstransactions RPC #231

jrick opened this issue Apr 3, 2015 · 1 comment

Comments

@jrick
Copy link
Member

jrick commented Apr 3, 2015

Opening a discussion to remove this extension RPC. I don't find the result format or the intended behavior useful, and creating result objects for it does not scale well.

The original issue (#27) mentioned that it may be useful for showing transactions which are relevant to some address, or a group of addresses. However, the result format it uses (it borrows from listtransactions) is nearly useless since it doesn't show transactions (but some parsed details about the transaction output, and other details which can't be correctly determined from just the transaction like the fee. Oh, and why do individual outputs show their own fee??).

Besides the rant about the stupid result format, we have accounts for address grouping now, and querying for transactions should be done by the account level (or perhaps later, by tag) so these can tracked as wallet is syncing. listaddresstransactions doesn't work this way, but instead must iterate over the wallet's entire transaction history from every account to find any relevant transactions. This obviously scales very poorly.

I'd like to hear other's opinions of removing the extension.

@arnuschky
Copy link

Querying the transactions for a subset of addresses is certainly useful for us, see #220. Of course, the result should then also include these transactions.

Might be most powerful if combined with some sort of tagging feature. Accounts are very limiting.

@jrick jrick added the json-rpc label Mar 17, 2016
alexlyp pushed a commit to alexlyp/btcwallet that referenced this issue May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@arnuschky @jrick and others