Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log directories must be specific to the network. #114

Closed
jrick opened this issue Jul 25, 2014 · 0 comments
Closed

Log directories must be specific to the network. #114

jrick opened this issue Jul 25, 2014 · 0 comments

Comments

@jrick
Copy link
Member

jrick commented Jul 25, 2014

Currently all network instances of btcwallet (mainnet, testnet3, and simnet) write to the same log file. The log file should be specific to the network, similar to how it's done by btcd.

@jrick jrick closed this as completed in dd85616 Jul 30, 2014
jrick added a commit to jrick/btcwallet that referenced this issue Nov 15, 2016
Because both the UI thread and the wallet RPC synchronization tasks
may access the wallet structure at the same time, access to the
structure must be synchronized.  Add a new Mutex<T> type which when
unlocked, provides access to the underlying locked instance (in this
case, the Wallet).  This ensures that (unless the wallet reference is
leaked outside of the exclusive access) all access to the wallet only
occurs when the lock is held.  This is also preferable to acquiring a
private mutex in each of the Wallet's public APIs as it allows
multiple public APIs to be called without any other tasks from
changing wallet state inbetween calls.

The mutex can only be acquired asynchronously.  This ensures that the
UI thread never blocks attempting to access wallet state.

Fixes btcsuite#114.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant