Remove circular dependency issue between btcec/v2 and main package#1823
Remove circular dependency issue between btcec/v2 and main package#1823Roasbeef merged 5 commits intobtcsuite:masterfrom
btcec/v2 and main package#1823Conversation
Pull Request Test Coverage Report for Build 1956823903
💛 - Coveralls |
|
EDIT: Removed that commit again since the author of the original PR already pushed a fix. |
776f825 to
38a9b6d
Compare
|
I merged #1780, so I think this just needs a rebase now. I think we'll also need to tag new |
Weird, I think we've done this in the past? Though maybe there's some other sneaky interaction here. |
Roasbeef
left a comment
There was a problem hiding this comment.
LGTM 🦟
Changes look good to me, if we really want to then we can eliminate the spew dep, but that only relies on the std-lib, so it doesn't bring any new deps into the fray.
|
Needs aa rebase, then we can merge this and push out the new tags, then update the mod files in another PR. |
38a9b6d to
999514c
Compare
|
Rebased! |
Remove circular dependency issue between `btcec/v2` and main package
Fixes #1822.
After merging this PR we need to push two tags:
chaincfg/chainhash/v1.0.0andbtcec/v2/v2.1.1.And I think the two tags cannot be on the same commit (because go mod is just mean that way), so I'd suggest adding
chaincfg/chainhash/v1.0.0to 7cc824e andbtcec/v2/v2.1.1to 4ad74cd.cc @Roasbeef.