Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: center qr code #6362

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

jackstar12
Copy link
Contributor

closes: #6361

example from issue now:
image

have yet to look at the other views which use the view

@petzsch
Copy link
Collaborator

petzsch commented Nov 4, 2024

schould the title (LNURL Withdraw) be centered as well? Looks slightly off still.

@dennisreimann dennisreimann requested a review from dstrukt November 4, 2024 16:46
@dennisreimann dennisreimann added the UI / UX Front-end issues, for front-end designers label Nov 4, 2024
@Jacksonearl2468
Copy link

Approved

@NicolasDorier NicolasDorier added this to the 2.0.2 milestone Nov 5, 2024
@pavlenex pavlenex modified the milestones: 2.0.2, 2.0.3 Nov 8, 2024
@dstrukt
Copy link
Member

dstrukt commented Nov 11, 2024

schould the title (LNURL Withdraw) be centered as well? Looks slightly off still.

We shouldn't center the title, it will mess up other modals.

The only other way to make this feel more balanced imo would be to expend the LNURL Withdraw to be full width of the container, but it's minor, and the current proposal, while I agree, looks a little off, is mostly fine.

Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested above, outside of maybe extending the LNURL Withdraw to full-width, this LGTM!

@NicolasDorier NicolasDorier merged commit acd7765 into btcpayserver:master Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI / UX Front-end issues, for front-end designers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pull-Payments / LNURL Withdraw QR Code view is not centered - looks weired
7 participants