Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions: Improve TX ID display #6190

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

dennisreimann
Copy link
Member

As per discussion with @NicolasDorier.

tx

@dstrukt dstrukt self-requested a review September 3, 2024 19:59
@NicolasDorier
Copy link
Member

@dennisreimann now I have another issue with this solution: CTRL + F searching for the txid in the list doesn't work anymore. :(

Is it something that can be improved in the component?

@NicolasDorier
Copy link
Member

NicolasDorier commented Sep 4, 2024

So I tried to set elastic="true" then I can CTRL+F. But the end of the transaction's id repeat itself.
Is it a bug from the component?

Copy link
Member

@dstrukt dstrukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional tACK!

(note: did not test the CTRL+F functionality)

@NicolasDorier
Copy link
Member

HUGE improvement for me

@NicolasDorier NicolasDorier merged commit a60c55c into btcpayserver:master Sep 12, 2024
4 checks passed
@dennisreimann dennisreimann deleted the txid branch October 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants