Wallet UI: Improve views #1763
Merged
Wallet UI: Improve views #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolatovumar
approved these changes
Jul 24, 2020
CSS fix
|
I want to merge! |
|
I want @Kukks to have a look first, just to ensure I haven't forgotten something in the send dialogs. |
|
@Kukks can you take a look and verify? |
Kukks
reviewed
Aug 3, 2020
Kukks
requested changes
Aug 3, 2020
BTCPayServer/Views/Stores/AddDerivationSchemes_HardwareWalletDialogs.cshtml
Outdated
Show resolved
Hide resolved
BTCPayServer/Views/Stores/AddDerivationSchemes_HardwareWalletDialogs.cshtml
Outdated
Show resolved
Hide resolved
|
Just tiny nits not even related to PR but since you adjusted the same area might as well include them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, some improvements for the wallet views. Mostly properly aligned things, set the correct widths for inputs and minor text updates.
Derivation scheme
Made the input a textarea, so that the full scheme is visible at once. Also removed this part of the text, that no one seems to remember what it was for :D
Send
Mostly alignment stuff and responsive improvements here …
Receive
Mostly alignment stuff and responsive improvements here …
Rescan
Input sizes and responsive improvements.
Settings
Input sizes and responsive improvements.