Repository navigation
Remove unused and static global parameters - #5
Merged
bstefanuk merged 23 commits intoFeb 11, 2025
Merged
Conversation
davidd-amd
reviewed
Feb 10, 2025
| @@ -42,7 +42,8 @@ | |||
| from .Toolchain.Assembly import AssemblyToolchain | |||
| from .Toolchain.Source import SourceToolchain | |||
| from .Common import globalParameters, HR, print1, print2, \ | |||
Collaborator
There was a problem hiding this comment.
I assume removing globalParams isn't in scope.
davidd-amd
reviewed
Feb 10, 2025
| for logicFileName in logicFiles: | ||
| (scheduleName, _, problemType, _, exactLogic, newLibrary) \ | ||
| = LibraryIO.parseLibraryLogicFile(logicFileName, cxxCompiler) | ||
| if problemType["DataType"].isHalf(): |
Collaborator
There was a problem hiding this comment.
What was this replaced with?
Owner
Author
There was a problem hiding this comment.
Only ever set not ever used.
davidd-amd
reviewed
Feb 10, 2025
| clientExe = ClientExecutable.getClientExecutable(cxxCompiler, cCompiler, buildDir) | ||
| for configFile in configPaths: | ||
| runScriptFile.write("{} --config-file {} {}\n".format(clientExe, configFile, globalParameters["ClientArgs"])) | ||
| runScriptFile.write("{} --config-file {}\n".format(clientExe, configFile)) |
Collaborator
There was a problem hiding this comment.
How can we remove args here?
Owner
Author
There was a problem hiding this comment.
ClientArgs is only ever an empty string
davidd-amd
reviewed
Feb 10, 2025
| # Treat ranges as pile of exacts: | ||
| for rsize in rangeSize.problemSizes: | ||
| self.exactProblemSizes.add(tuple(rsize)) | ||
| else: |
Collaborator
There was a problem hiding this comment.
We never take the else branch?
Owner
Author
There was a problem hiding this comment.
Nope, never, "ExpandRanges" is only ever set to True, and isn't overridden in any logic files.
bstefanuk
added a commit
that referenced
this pull request
Feb 13, 2025
* feat: no global working path with asserts * fix: bad import statement * fix: different build_tmp dir in cmake than tensile * fix: incorrect pathing in Tensile benchmarking * fix: string wrap paths for assert checks * fix: ensure all paths are built * fix: missing global parameter warning * fix: ensure library logic path is built * fix: client writer paths * fix: use child path for client libraries * remove PrintTiming from global params * remove another assert * restore PrintTiming * fix: reviewer comments * refactor: use env var for @timing decorator * refactor: remove library print debug * refactor: remove exit after kernel gen option * style: remove commented code * refactor: move common to a module * feat: remove 'CustomKernelDirectory' global param * fix: amd clang version global param * fix: second pass on amd clang version * fix: imports for bolted on ops scripts * chore: remove safety asserts * chore: create more separation in Common * fix: missing line at eof * fix: basic reviewer comments * chore: move global dependenct funcs to GlobalParameters.py * fix: pass global params to splitArchs * style: don't format caps funcs * fix: bad import * Add TensileLogic program to verify matrix instructions (#3) * Remove unused and static global parameters (#5) * fix: purge library-print-debug * feat: make build paths static * feat: remove 'SortProblems' global param * feat: remove 'ExpandRanges' global param * feat: remove 'WavefrontWidth' global param * feat: remove 'ValidateLibrary' global param * feat: remove 'EnableHalf' and 'ClientArgs' global params * feat: prefer profile decorator over 'Profiler' global param * chore: remove 'LibraryPrintDebug' from build_client.yaml * feat: remove 'MaxFileName' from global params * Update preferred search paths (#4) * fix: remove files updated by precommit in merge * fix: remove log file * Copyright update --------- Co-authored-by: David Dixon <david.dixon@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.