Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signalr transport #16

Merged
merged 2 commits into from
May 29, 2023
Merged

feat: signalr transport #16

merged 2 commits into from
May 29, 2023

Conversation

neon-sunset
Copy link
Collaborator

Contributes to #15

You may want to hold off with releasing a new version until I implement #14 too

@bsdayo
Copy link
Owner

bsdayo commented May 29, 2023

That's great! I didn't even realize BingChat used SignalR XD

But there is a small issue, are there some changes that are not included in this PR? For example, many properties in BingChatConversationRequest (Type, InvocationId, etc.) have been removed, but they are still referenced in BingChatRequest.cs. This causes a compilation error.

Could you take a look at it?

@bsdayo
Copy link
Owner

bsdayo commented May 29, 2023

That works! ❤️

@bsdayo bsdayo merged commit 8f85b1c into bsdayo:main May 29, 2023
@neon-sunset neon-sunset deleted the signalr branch May 29, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants