Topic as will.topic #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this commit history is still wrong, you currently have 5 commits, 2 of which are old or are merge commits. Ideally an open PR should be branched off of a recent commit from this repo, with no merge commits or other extraneous items. I've made a similar comment on another repo of mine, this might contain some helpful git commands to work with forks and upstream remotes: bschwind/opencascade-rs#7 (comment) Let me know if you need any help, I know git commands aren't the most intuitive thing. |
Nereuxofficial
force-pushed
the
will-topic
branch
from
675ef89 to
7fea543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with a cherry-picked commit in order not to include the other irrelevant commits in this PR