-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two commits (can be cherrypicked): Custom Env vars for Perl in settings, and convert tilda to home in paths #119
Conversation
NOTE: I tested this under MacOS (no Windows and I suspect it might be a different way of substituting Windows "home" or other relativeness). |
This looks great, thanks for putting this together! I'll do some testing this weekend and merge it in. Some comments: I don't think we'd need to disable the tilde expansion. Currently, tilde's simply don't work so having it on all the time is probably the best. Looks like they considered adding it in node, but decided against it: nodejs/node#684 On Windows, the equivalent is probably PerlEnv and PerlEnvAdd both make sense as well. I suspect Add is the more common case, where someone just needs to add or override a variable. Clearing out variables might have some unexpected effects, especially if someone's perl setup uses Thanks! |
Introduced two new environment variables: perlEnv and perlEnvAdd. - perlEnv: Hash. Pass environment variables to the perl executable. Skipped if undefined. - perlEnvAdd: Boolean. Add environment variables to current environment, or totally replace (perlEnv related). Default is true.
67b2d7f
to
3bf5680
Compare
Good point. I reworked the idea of PerlEnv: two variables:
More clean, and added by default, and perlEnvAdd can be used rarely. |
3bf5680
to
3e9af99
Compare
Also: removed
commit at all, no need to on/off tildas' expansion. |
3e9af99
to
53e29c5
Compare
... and removed Windows "placeholder" |
This commit introduces functionality to expand leading tildas (~) in paths. The tilde is a common shorthand for the home directory in Unix-like operating systems, and this change allows our application to interpret and handle these paths correctly. Previously, if a user entered a path with a leading tilde, the application would not recognize it as a valid path. With this update, the application will now expand any leading tilde to the current user's home directory, allowing for more flexible and intuitive path input. This change improves the user experience by accepting a wider range of valid inputs and aligns the application's path handling behavior with established conventions in Unix-like operating systems.
53e29c5
to
d439d93
Compare
This is great, my apologies for the slow merge. Thanks again for putting this together! |
Feature 1:
Add support for custom Perl environment variables
Introduced two new environment variables: perlEnv and perlEnvAdd.
Feature 2:
Add support for expanding leading tildas in paths