Fix draw-by-repetition detection #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsamseth
force-pushed
the
bug/draw-by-repetition
branch
2 times, most recently
from
8b302a5 to
4a93656
Compare
It would not count pre-root moves in the detection, meaning it only found repetitions in-search. This should hopefully cause a _lot_ less draw-by-repetition in play tests, and less/no drawing in won positions. Edit: Still a lot of draw-by-repetition in play tests. But spot-checking them, they all make sense. Positions are entirely equal, and the side with slightly less control semi-forces the repetition with checks. Time will show if this still draws won positions. We probably get a lot of repetition because the evaluation is so simple, and nobody knows how to make progress in early endgames.
bsamseth
force-pushed
the
bug/draw-by-repetition
branch
from
4a93656 to
3d0da07
Compare
|
Testing with adjudication shows no difference. Without adjudication, this does make a significant difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would not count pre-root moves in the detection, meaning it only found repetitions in-search. This should hopefully cause a lot less draw-by-repetition in play tests, and less/no drawing in won positions.