Skip to content

Commit

Permalink
CI fix
Browse files Browse the repository at this point in the history
  • Loading branch information
bryanlopezinc committed Nov 2, 2023
1 parent 8a14f82 commit 734d26a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ jobs:
- name: Install Dependencies
run: composer install -q --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist

- name: Dump
run: composer dump-autoload

- name: Generate key
run: php artisan key:generate

Expand All @@ -54,4 +51,4 @@ jobs:
php artisan passport:keys --force
- name: Run tests
run: php artisan test
run: php artisan test --filter=Tests\\Feature\\CreateBookmarkTest
4 changes: 2 additions & 2 deletions app/Services/CreateBookmarkService.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace App\Services;

use App\ValueObjects\Url;
use App\ValueObjects\UserID;
use App\ValueObjects\UserId;
use App\Http\Requests\CreateOrUpdateBookmarkRequest;
use App\Jobs\UpdateBookmarkWithHttpResponse;
use App\Models\Bookmark;
Expand All @@ -29,7 +29,7 @@ public function fromRequest(CreateOrUpdateBookmarkRequest $request): void
$data = [
'url' => new Url($request->validated('url')),
'createdOn' => (string)now(),
'userID' => UserID::fromAuthUser()->value(),
'userID' => UserId::fromAuthUser()->value(),
'tags' => $request->validated('tags', new MissingValue()),
'title' => $request->validated('title', new MissingValue()),
'description' => $request->input('description', new MissingValue()),
Expand Down
2 changes: 1 addition & 1 deletion app/ValueObjects/UserId.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use App\Exceptions\InvalidResourceIdException;

final class UserID
final class UserId
{
public function __construct(protected readonly int $id)
{
Expand Down

0 comments on commit 734d26a

Please sign in to comment.