Skip to content

fix: DirectiveAttributes type - #97

Merged
Princesseuh merged 2 commits into
bruits:mainfrom
HiDeoo:hd/fix-directive-attributes-type
Jun 16, 2026
Merged

Princesseuh merged 2 commits into
bruits:mainfrom
HiDeoo:hd/fix-directive-attributes-type

Conversation

@HiDeoo

@HiDeoo HiDeoo commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

This PR updates the DirectiveAttributes type definition to match the one from mdast-util-directive.

Added a comment with links to explain why we can update the type without changing the implementation, as mdast-util-directive omits null and undefined values while still allowing them in the type definition.

@codspeed

codspeed Bot commented Jun 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing HiDeoo:hd/fix-directive-attributes-type (8de6512) with main (6bcdf06)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@HiDeoo
HiDeoo marked this pull request as ready for review June 16, 2026 10:59

@Princesseuh Princesseuh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Princesseuh
Princesseuh merged commit 0d36b24 into bruits:main Jun 16, 2026
5 checks passed
@HiDeoo HiDeoo mentioned this pull request Jun 16, 2026
9 of 10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants