*: run clippy for new toolchain

The biggest changes here are - replace .into_iter() with .iter() where possible - use inclusive ranges where possible The first is a good lint. The second I'm less sure about - the lint says inclusive ranges may be more readable, but it's easy tot imagine cases where they are not. I've just done as the lint says though. Signed-off-by: Brian Anderson <[email protected]>
brson · Jan 9, 2019 · f34e09d · f34e09d
1 parent 8d8c998
commit f34e09d
Show file tree

Hide file tree

Showing 49 changed files with 97 additions and 101 deletions.
diff --git a/Makefile b/Makefile
@@ -45,12 +45,12 @@ pre-clippy: unset-override
 
 clippy: pre-clippy
 	@cargo clippy --all --all-targets -- \
-		-A module_inception -A needless_pass_by_value -A cyclomatic_complexity \
-		-A unreadable_literal -A should_implement_trait -A verbose_bit_mask \
-		-A implicit_hasher -A large_enum_variant -A new_without_default \
-		-A new_without_default_derive -A neg_cmp_op_on_partial_ord \
-		-A too_many_arguments -A excessive_precision -A collapsible_if \
-		-A blacklisted_name -A needless_range_loop
+		-A clippy::module_inception -A clippy::needless_pass_by_value -A clippy::cyclomatic_complexity \
+		-A clippy::unreadable_literal -A clippy::should_implement_trait -A clippy::verbose_bit_mask \
+		-A clippy::implicit_hasher -A clippy::large_enum_variant -A clippy::new_without_default \
+		-A clippy::new_without_default_derive -A clippy::neg_cmp_op_on_partial_ord \
+		-A clippy::too_many_arguments -A clippy::excessive_precision -A clippy::collapsible_if \
+		-A clippy::blacklisted_name -A clippy::needless_range_loop
 
 dev: format clippy
 	@env FAIL_POINT=1 make test

diff --git a/components/codec/src/byte.rs b/components/codec/src/byte.rs
@@ -561,7 +561,7 @@ mod tests {
             let encoded_len = MemComparableByteCodec::encoded_len(payload_len);
             let mut payload_encoded: Vec<u8> =
                 vec![0; encoded_prefix_len + encoded_len + encoded_suffix_len];
-            #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))]
+            #[cfg_attr(feature = "cargo-clippy", allow(clippy::needless_range_loop))]
             for i in 0..encoded_prefix_len {
                 payload_encoded[i] = rand::random();
             }
@@ -574,7 +574,7 @@ mod tests {
                     MemComparableByteCodec::encode_all(src, dest);
                 }
             }
-            #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))]
+            #[cfg_attr(feature = "cargo-clippy", allow(clippy::needless_range_loop))]
             for i in encoded_prefix_len + encoded_len..encoded_suffix_len {
                 payload_encoded[i] = rand::random();
             }

diff --git a/components/codec/src/number.rs b/components/codec/src/number.rs
@@ -396,7 +396,7 @@ impl NumberCodec {
     /// Returns `Error::BufferTooSmall` if there is not enough space to decode the whole VarInt.
     #[inline]
     pub fn try_decode_var_u64(buf: &[u8]) -> Result<(u64, usize)> {
-        #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))]
+        #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))]
         unsafe {
             let mut ptr = buf.as_ptr();
             let len = buf.len();
@@ -970,7 +970,7 @@ mod tests {
         get_u16_samples().into_iter().map(|v| v as i16).collect()
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))]
     fn get_u32_samples() -> Vec<u32> {
         let mut samples = vec![
             (::std::i32::MIN as u32),
@@ -994,7 +994,7 @@ mod tests {
         get_u32_samples().into_iter().map(|v| v as i32).collect()
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))]
     fn get_u64_samples() -> Vec<u64> {
         let mut samples = vec![
             (::std::i64::MIN as u64),
@@ -1018,7 +1018,7 @@ mod tests {
         get_u64_samples().into_iter().map(|v| v as i64).collect()
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))]
     fn get_f64_samples() -> Vec<f64> {
         vec![
             -1.0,
@@ -1142,7 +1142,7 @@ mod tests {
                     }
 
                     // the cursor leaves sufficient space for encoding
-                    for pos in 0usize..buf_len - len + 1 {
+                    for pos in 0usize..=buf_len - len {
                         let buf = payload.clone();
                         let mut cursor = ::std::io::Cursor::new(buf);
                         cursor.set_position(pos as u64);
@@ -1220,7 +1220,7 @@ mod tests {
                     }
 
                     // the cursor leaves sufficient space for decoding
-                    for pos in 0usize..buf_len - len + 1 {
+                    for pos in 0usize..=buf_len - len {
                         let mut buf = payload.clone();
                         super::NumberCodec::$enc(&mut buf.as_mut_slice()[pos..], sample);
                         let mut cursor = ::std::io::Cursor::new(buf);
@@ -1364,7 +1364,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp))]
     fn test_f64() {
         test_mem_compare!(
             get_f64_samples(),
@@ -1377,7 +1377,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp))]
     fn test_f64_desc() {
         test_mem_compare!(
             get_f64_samples(),
@@ -1456,7 +1456,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::float_cmp))]
     fn test_f64_le() {
         test_codec!(
             get_f64_samples(),
@@ -1517,7 +1517,7 @@ mod tests {
                     }
 
                     // the cursor leaves sufficient space for encoding
-                    for pos in 0usize..buf_len - super::MAX_VARINT64_LENGTH + 1 {
+                    for pos in 0usize..=buf_len - super::MAX_VARINT64_LENGTH {
                         let buf = payload.clone();
                         let mut cursor = ::std::io::Cursor::new(buf);
                         cursor.set_position(pos as u64);
@@ -1572,7 +1572,7 @@ mod tests {
                     for _ in 0..buf_len {
                         payload.push(rand::random::<u8>());
                     }
-                    for pos in 0usize..buf_len - len + 1 {
+                    for pos in 0usize..=buf_len - len {
                         let mut buf = payload.clone();
                         buf[pos..pos + len].clone_from_slice(&base_buf[0..len]);
 

diff --git a/components/test_raftstore/src/cluster.rs b/components/test_raftstore/src/cluster.rs
@@ -297,7 +297,7 @@ impl<T: Simulator> Cluster<T> {
             .map(|region| {
                 region
                     .get_peers()
-                    .into_iter()
+                    .iter()
                     .map(|p| p.get_store_id())
                     .collect()
             })

diff --git a/components/test_storage/src/assert_storage.rs b/components/test_storage/src/assert_storage.rs
@@ -210,7 +210,7 @@ impl<E: Engine> AssertionStorage<E> {
     }
 
     pub fn batch_get_ok(&self, keys: &[&[u8]], ts: u64, expect: Vec<&[u8]>) {
-        let keys: Vec<Key> = keys.into_iter().map(|x| Key::from_raw(x)).collect();
+        let keys: Vec<Key> = keys.iter().map(|x| Key::from_raw(x)).collect();
         let result: Vec<Vec<u8>> = self
             .store
             .batch_get(self.ctx.clone(), &keys, ts)

diff --git a/src/config.rs b/src/config.rs
@@ -812,7 +812,7 @@ pub mod log_level_serde {
             .ok_or_else(|| D::Error::invalid_value(Unexpected::Str(&string), &"a valid log level"))
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(trivially_copy_pass_by_ref))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::trivially_copy_pass_by_ref))]
     pub fn serialize<S>(value: &Level, serializer: S) -> Result<S::Ok, S::Error>
     where
         S: Serializer,

diff --git a/src/coprocessor/codec/batch/column.rs b/src/coprocessor/codec/batch/column.rs
@@ -233,7 +233,7 @@ impl BatchColumn {
     ///
     /// Panics if `field_type` doesn't match current column's type.
     #[inline]
-    #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))]
     pub fn push_datum(
         &mut self,
         mut raw_datum: &[u8],

diff --git a/src/coprocessor/codec/batch/rows.rs b/src/coprocessor/codec/batch/rows.rs
@@ -347,7 +347,7 @@ mod tests {
     fn raw_row_from_datums(datums: impl AsRef<[Option<Datum>]>, comparable: bool) -> Vec<Vec<u8>> {
         datums
             .as_ref()
-            .into_iter()
+            .iter()
             .map(|some_datum| {
                 let mut ret = Vec::new();
                 if some_datum.is_some() {

diff --git a/src/coprocessor/codec/chunk/column.rs b/src/coprocessor/codec/chunk/column.rs
@@ -355,7 +355,7 @@ impl Column {
             col.fixed_len * col.length
         } else {
             col.var_offsets.clear();
-            for _ in 0..length + 1 {
+            for _ in 0..=length {
                 col.var_offsets.push(number::decode_i32_le(buf)? as usize);
             }
             col.var_offsets[col.length]

diff --git a/src/coprocessor/codec/mysql/decimal.rs b/src/coprocessor/codec/mysql/decimal.rs
@@ -653,7 +653,7 @@ fn do_div_mod(
                 }
             }
             let mut carry = 0;
-            for (r_idx, l_idx) in (r_start..r_stop).rev().zip((0..l_idx + r_len + 1).rev()) {
+            for (r_idx, l_idx) in (r_start..r_stop).rev().zip((0..=l_idx + r_len).rev()) {
                 let x = guess * i64::from(rhs.word_buf[r_idx]);
                 let hi = x / i64::from(WORD_BASE);
                 let lo = x - hi * i64::from(WORD_BASE);
@@ -668,7 +668,7 @@ fn do_div_mod(
             if carry > 0 {
                 guess -= 1;
                 let mut carry = 0;
-                for (r_idx, l_idx) in (r_start..r_stop).rev().zip((0..l_idx + r_len + 1).rev()) {
+                for (r_idx, l_idx) in (r_start..r_stop).rev().zip((0..=l_idx + r_len).rev()) {
                     add(buf[l_idx], rhs.word_buf[r_idx], &mut carry, &mut buf[l_idx]);
                 }
             }
@@ -1211,7 +1211,7 @@ impl Decimal {
                     // e.g ceiling 3.0001 to scale 1, gets 3.1
                     let idx = to_idx + frac_word_cnt as i8 - frac_words_to;
                     if idx > to_idx {
-                        res.word_buf[(to_idx + 1) as usize..(idx as usize + 1)]
+                        res.word_buf[(to_idx + 1) as usize..=(idx as usize)]
                             .iter()
                             .any(|c| *c != 0)
                     } else {
@@ -1441,18 +1441,18 @@ impl Decimal {
                 word_shift = new_front / DIGITS_PER_WORD as isize;
                 let to = ((beg / DIGITS_PER_WORD) as isize - word_shift) as usize;
                 let barier = (((end - 1) / DIGITS_PER_WORD) as isize - word_shift) as usize;
-                for i in to..barier + 1 {
+                for i in to..=barier {
                     res.word_buf[i] = res.word_buf[i + word_shift as usize];
                 }
-                for i in barier + 1..barier + word_shift as usize + 1 {
+                for i in barier + 1..=barier + word_shift as usize {
                     res.word_buf[i] = 0;
                 }
                 word_shift = -word_shift;
             } else {
                 word_shift = (1 - new_front) / DIGITS_PER_WORD as isize;
                 let to = (((end - 1) / DIGITS_PER_WORD) as isize + word_shift) as usize;
                 let barier = ((beg / DIGITS_PER_WORD) as isize + word_shift) as usize;
-                for i in (barier..to + 1).rev() {
+                for i in (barier..=to).rev() {
                     res.word_buf[i] = res.word_buf[i - word_shift as usize];
                 }
                 for i in barier - word_shift as usize..barier {
@@ -1472,7 +1472,7 @@ impl Decimal {
             0
         };
         if new_point_word > end_word {
-            for i in end_word + 1..new_point_word + 1 {
+            for i in end_word + 1..=new_point_word {
                 res.word_buf[i as usize] = 0;
             }
         } else {
@@ -1616,7 +1616,7 @@ impl Decimal {
         let mut inner_idx = 0;
         let mut word_idx = int_word_cnt as usize;
         let mut word = 0;
-        for c in bs[int_idx - int_cnt as usize..int_idx].into_iter().rev() {
+        for c in bs[int_idx - int_cnt as usize..int_idx].iter().rev() {
             word += u32::from(c - b'0') * TEN_POW[inner_idx];
             inner_idx += 1;
             if inner_idx == DIGITS_PER_WORD as usize {
@@ -1715,7 +1715,7 @@ macro_rules! enable_conv_for_int {
     ($s:ty, $t:ty) => {
         impl From<$s> for Decimal {
             fn from(t: $s) -> Decimal {
-                #[cfg_attr(feature = "cargo-clippy", allow(cast_lossless))]
+                #[cfg_attr(feature = "cargo-clippy", allow(clippy::cast_lossless))]
                 (t as $t).into()
             }
         }
@@ -2297,7 +2297,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg_attr(feature = "cargo-clippy", allow(approx_constant))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::approx_constant))]
     fn test_f64() {
         let cases = vec![
             ("12345", 12345f64),

diff --git a/src/coprocessor/codec/mysql/time/mod.rs b/src/coprocessor/codec/mysql/time/mod.rs
@@ -77,7 +77,7 @@ pub fn zero_datetime(tz: Tz) -> Time {
     Time::new(zero_time(tz), TimeType::DateTime, mysql::DEFAULT_FSP).unwrap()
 }
 
-#[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
+#[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))]
 #[inline]
 fn ymd_hms_nanos<T: TimeZone>(
     tz: T,
@@ -1086,7 +1086,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg_attr(feature = "cargo-clippy", allow(zero_prefixed_literal))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::zero_prefixed_literal))]
     fn test_parse_datetime_system_timezone() {
         // Basically, we check whether the parse result is the same when construcing using local.
         let tables = vec![

diff --git a/src/coprocessor/codec/table.rs b/src/coprocessor/codec/table.rs
@@ -120,7 +120,7 @@ pub fn encode_row(row: Vec<Datum>, col_ids: &[i64]) -> Result<Vec<u8>> {
         ));
     }
     let mut values = Vec::with_capacity(cmp::max(row.len() * 2, 1));
-    for (&id, col) in col_ids.into_iter().zip(row) {
+    for (&id, col) in col_ids.iter().zip(row) {
         values.push(Datum::I64(id));
         let fc = flatten(col)?;
         values.push(fc);

diff --git a/src/coprocessor/dag/expr/builtin_cast.rs b/src/coprocessor/dag/expr/builtin_cast.rs
@@ -755,7 +755,7 @@ mod tests {
     fn test_cast_as_int() {
         let mut ctx = EvalContext::new(Arc::new(EvalConfig::default_for_test()));
         let t = Time::parse_utc_datetime("2012-12-12 12:00:23", 0).unwrap();
-        #[cfg_attr(feature = "cargo-clippy", allow(inconsistent_digit_grouping))]
+        #[cfg_attr(feature = "cargo-clippy", allow(clippy::inconsistent_digit_grouping))]
         let time_int = 2012_12_12_12_00_23i64;
         let duration_t = Duration::parse(b"12:00:23", 0).unwrap();
         let cases = vec![
@@ -880,7 +880,7 @@ mod tests {
     fn test_cast_as_real() {
         let mut ctx = EvalContext::new(Arc::new(EvalConfig::default_for_test()));
         let t = Time::parse_utc_datetime("2012-12-12 12:00:23", 0).unwrap();
-        #[cfg_attr(feature = "cargo-clippy", allow(inconsistent_digit_grouping))]
+        #[cfg_attr(feature = "cargo-clippy", allow(clippy::inconsistent_digit_grouping))]
         let int_t = 2012_12_12_12_00_23u64;
         let duration_t = Duration::parse(b"12:00:23", 0).unwrap();
         let cases = vec![

diff --git a/src/coprocessor/dag/expr/builtin_string.rs b/src/coprocessor/dag/expr/builtin_string.rs
@@ -421,7 +421,7 @@ impl ScalarFunc {
         }
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(wrong_self_convention))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::wrong_self_convention))]
     #[inline]
     pub fn from_base64<'a, 'b: 'a>(
         &'b self,

diff --git a/src/lib.rs b/src/lib.rs
@@ -27,7 +27,7 @@
 #![feature(range_contains)]
 // Currently this raises some false positives, so we allow it:
 // https://github.com/rust-lang-nursery/rust-clippy/issues/2638
-#![cfg_attr(feature = "cargo-clippy", allow(nonminimal_bool))]
+#![cfg_attr(feature = "cargo-clippy", allow(clippy::nonminimal_bool))]
 
 extern crate alloc;
 extern crate backtrace;

diff --git a/src/pd/pd.rs b/src/pd/pd.rs
@@ -492,7 +492,7 @@ impl<T: PdClient> Runner<T> {
 
                         if pd_region
                             .get_peers()
-                            .into_iter()
+                            .iter()
                             .all(|p| p.get_id() != peer.get_id())
                         {
                             // Peer is not a member of this Region anymore. Probably it's removed out.

diff --git a/src/pd/util.rs b/src/pd/util.rs
@@ -433,7 +433,7 @@ pub fn try_connect_leader(
     let mut resp = None;
     // Try to connect to other members, then the previous leader.
     'outer: for m in members
-        .into_iter()
+        .iter()
         .filter(|m| *m != previous_leader)
         .chain(&[previous_leader.clone()])
     {

diff --git a/src/raftstore/store/fsm/batch.rs b/src/raftstore/store/fsm/batch.rs
@@ -468,7 +468,7 @@ mod tests {
         }
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::type_complexity))]
     fn new_runner(
         cap: usize,
     ) -> (

diff --git a/src/raftstore/store/fsm/peer.rs b/src/raftstore/store/fsm/peer.rs
@@ -1630,7 +1630,7 @@ impl<T: Transport, C: PdClient> Store<T, C> {
         };
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(if_same_then_else))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::if_same_then_else))]
     pub fn on_raft_gc_log_tick(&mut self, event_loop: &mut EventLoop<Self>) {
         // As leader, we would not keep caches for the peers that didn't response heartbeat in the
         // last few seconds. That happens probably because another TiKV is down. In this case if we

diff --git a/src/raftstore/store/fsm/store.rs b/src/raftstore/store/fsm/store.rs
@@ -120,7 +120,7 @@ where
 }
 
 impl<T: Transport, C: PdClient> Store<T, C> {
-    #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))]
     pub fn new(
         ch: StoreChannel,
         meta: metapb::Store,

diff --git a/src/raftstore/store/peer.rs b/src/raftstore/store/peer.rs
@@ -2360,7 +2360,7 @@ mod tests {
         }
     }
 
-    #[cfg_attr(feature = "cargo-clippy", allow(useless_vec))]
+    #[cfg_attr(feature = "cargo-clippy", allow(clippy::useless_vec))]
     #[test]
     fn test_request_inspector() {
         struct DummyInspector {