Move to Go modules #338
Merged
Move to Go modules #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
commented
Jul 27, 2020
| @@ -0,0 +1,34 @@ | |||
| module github.com/browsh-org/browsh/interfacer | |||
|
|
|||
| go 1.14 | |||
There was a problem hiding this comment.
Is this version an issue? What minimum version of Go is being targeted?
There was a problem hiding this comment.
I never encountered any version related issues. I just pinned a version for the sake of pinning, in case there were unforeseeable issues with future versions. If latest Go works, then let's bump.
No longer needed due to the move to Go modules.
Allows installation with `go install ./cmd/browsh`, no need to specify output.
- Remove references to dep and GOPATH - Use code blocks for commands - Update for new build instructions
|
Thank you SO much! It's important to be keeping up with Go's best practices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #238, I hope.
Go modules are the standard way of dealing with dependencies in Go. I also couldn't launch
./browshbecause it couldn't find the extension... Importing it without the leading forward slash worked, so I added that in the PR. I believe I generated it the correct way, so I'm not sure why I needed to make this change.