This repository was archived by the owner on Jun 11, 2024. It is now read-only.
Issue-131 har default values #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiturutin
requested review from
dpowell,
epic-alex-rodionov,
ericbeland and
rkuzsma
dpowell
approved these changes
Jul 25, 2019
Contributor
dpowell
left a comment
dpowell
left a comment
There was a problem hiding this comment.
Good catch to test the REST serialization as well.
ericbeland
approved these changes
Jul 25, 2019
Contributor
ericbeland
left a comment
ericbeland
left a comment
There was a problem hiding this comment.
This looks good. If we haven't, before we merge, can we run through the fields in the spec and make sure there aren't others. The types are listed in the spec here: http://www.softwareishard.com/blog/har-12-spec/
kiturutin
force-pushed
the
issue-131-har-default-values
branch
from
c6eedce to
79e1a54
Compare
kiturutin
force-pushed
the
issue-131-har-default-values
branch
from
79e1a54 to
5e79587
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.