Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to Node v0.12.7 #4

Closed
wants to merge 2 commits into from
Closed

Upgraded to Node v0.12.7 #4

wants to merge 2 commits into from

Conversation

JamesMessinger
Copy link

This PR resolves Issue #1 and Issue #2, and also includes PR #3.

I've updated index.js to the latest code from Node v0.12.7. This code was copied straight from joyent/node/lib/path.js

I've also added util as a dependency in package.json, since it is used by the new code.

@cjblomqvist
Copy link

This does not fix #1 as briefly mentioned in #6 because this relies on process.platform being available - which it isn't in the browser (unless manually added, but that kind of forfeits the whole purpose of having a module fixing it for you automatically). And a browserify that doesn't work in the browser doesn't really sound too useful either... ;)

I have nothing against the PR though. And my install step can easily be incorporated to fix the issue.

@cjblomqvist
Copy link

By the way, I use this shrinkwrap in order to use my version of path-browserify:

{
  "dependencies": {
    "browserify": {
      "version": "12.0.1",
      "from": "browserify@>=12.0.1 <13.0.0",
      "dependencies": {
        "path-browserify": {
          "version": "0.1.0",
          "from": "git://github.com/bbweb/path-browserify.git#general-version"
        }
      }
    }
  }
}

@Hypercubed
Copy link

Could really use this. path.posix.resolve is failing.

@goto-bus-stop
Copy link
Member

#12 upgraded to Node 8. i'll do a release once tests are ported (#13). thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants