fix for packageTransform option bug #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published in 1.8.1. Thanks for the patch! |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi James,
Been banging my head against the wall trying to track down an issue related to the packageFilter option. Looks like there is a bug in module deps to whereas at times it will not apply the package filter to parsed package jsons. Specifically, in the "walk" function, if lookupPkg needs to be called because
pkg.__dirnameis missing (line 129), the packageFilter is not applied to the parsed package json. However, it IS applied in the case thatpkg.__dirnameis present, as the pkg comes back from resolver already transformed. The PR fixes the issue so that the package filter is applied consistently across both cases.