Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional acorn options. #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add optional acorn options. #129

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2017

Part of multiple pull-requests, so acorn options can flow like:
module-deps -> detective

Also see:
browserify/detective#69

Copy link
Collaborator

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link
Author

ghost commented Mar 28, 2017

Does it need more work?

@@ -33,6 +33,7 @@ function Deps (opts) {
});
};
this.cache = opts.cache;
this.acorn = {parse: {acorn: opts.acorn}};
Copy link
Member

@ahdinosaur ahdinosaur Mar 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jvanveen, thanks for the contribution! is acorn the best name for this option? and why is it nested in parse? your answer is as good as any, so just wondering your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants