New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give to FF a chance to set the ‘xhr.responseType’ #74

Open

enricostara wants to merge 2 commits into browserify:master from enricostara:master

enricostara commented Nov 10, 2014

Give to FireFox a chance to set the xhr.responseType = 'arraybuffer' on async request.
See also: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Sending_and_Receiving_Binary_Data

enricostara added 2 commits

November 10, 2014 16:38


          Give to FF a chance to set the ‘xhr.responseType’

f8a4cea


          Check first if the response body is defined

0adc080

Author

enricostara commented Nov 25, 2014

You can receive a null response body if try to do a request to an unreachable site.
So we need to check first if the response body is defined.
You can find a test here:
https://github.com/enricostara/telegram-mt-node/blob/master/test/net/http-connection.test.js

enricostara closed this

enricostara reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet