Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screw MSIE 8/9 support. #47

Closed
wants to merge 2 commits into from
Closed

Conversation

diegocr
Copy link

@diegocr diegocr commented Feb 11, 2018

Hello,

I would like to suggest to be pragmatic here and screw support for these rather obsolete browsers.

Mainly, to prevent the bloated code, and also i think it will make further maintainability with the Node.js events API easier in the long run.

Thanks for consideration.

This reverts commit 3229579.

Conflicts:
	package.json
@goto-bus-stop
Copy link
Member

hmm, events is pretty heavily depended upon as a browser version of node's events, most notably by browserify and webpack; dropping IE8 support here would mean that browserify and webpack bundles that use the core events module would also no longer work in IE8 (and other ES3 browsers).

@diegocr
Copy link
Author

diegocr commented Feb 12, 2018

That's quite right... however, how many would be affected? all products i'm familiar with have dropped support for it years ago already.

@goto-bus-stop
Copy link
Member

IE9 supports most of ES5 so we can probably support that fairly easily. I'm OK with doing this otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants