-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Node.js 8 events API #40
Conversation
Disabled specific Node.js bits: domain and process. Also replaced a template string by concatenation.
Because it is created using `Object.create(null)` in the `events` module.
Anyone knows how to fix the
|
@defunctzombie Thanks, it would be a pleasure to help maintaining this project. |
Ported the imported code to ES5 but the new test suite does not work with IE 8 due to the usage of `Array.forEach`.
@Gozala Do you still maintain this project? Or should we switch to another package like |
@cedx @defunctzombie has being maintaining it for quite some time now, but it looks like he's no longer able. I'm happy to let you take over since @defunctzombie seems to be onboard with that as well. |
@cedx I just have added you to the collaborators list, if you'll tell me your npm name I'll add you there as well. |
hey, i'm very interested in getting this in--any way i can help out? |
@goto-bus-stop wanna take over this pull so it actually passes test ? |
@Gozala I think the test failure is because this is a PR, and travis doesn't expose the SauceLabs authentication keys to PR builds (only branch builds). the tests themselves pass, but CI can't talk to saucelabs. it should turn green after merge |
It seems like this is still failing on IE 8/9. Sadly I don't have no time to put into this if someone want's to fix help maintain this project comment on #43 |
Let's try again! @defunctzombie, @connor4312, I don't want this package to be abandoned :)
This PR fixes issue #29. As for the PR #32, the code was copied from Node.js source and adapted:
domain
andprocess
const
statements byvar
ones