Skip to content

Commit

Permalink
avoid deepStrictEqual
Browse files Browse the repository at this point in the history
  • Loading branch information
goto-bus-stop committed Feb 16, 2018
1 parent 44ed710 commit 5a9eb9b
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 15 deletions.
17 changes: 12 additions & 5 deletions tests/events-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,23 @@ var assert = require('assert');
var EE = new EventEmitter();
var m = function() {};
EE.on('foo', function() {});
assert.deepStrictEqual(['foo'], EE.eventNames());
assert.equal(1, EE.eventNames().length);
assert.equal('foo', EE.eventNames()[0]);
EE.on('bar', m);
assert.deepStrictEqual(['foo', 'bar'], EE.eventNames());
assert.equal(2, EE.eventNames().length);
assert.equal('foo', EE.eventNames()[0]);
assert.equal('bar', EE.eventNames()[1]);
EE.removeListener('bar', m);
assert.deepStrictEqual(['foo'], EE.eventNames());
assert.equal(1, EE.eventNames().length);
assert.equal('foo', EE.eventNames()[0]);

if (typeof Symbol !== 'undefined') {
var s = Symbol('s');
EE.on(s, m);
assert.deepStrictEqual(['foo', s], EE.eventNames());
assert.equal(2, EE.eventNames().length);
assert.equal('foo', EE.eventNames()[0]);
assert.equal(s, EE.eventNames()[1]);
EE.removeListener(s, m);
assert.deepStrictEqual(['foo'], EE.eventNames());
assert.equal(1, EE.eventNames().length);
assert.equal('foo', EE.eventNames()[0]);
}
22 changes: 12 additions & 10 deletions tests/special-event-names.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ var assert = require('assert');
var ee = new EventEmitter();
var handler = function() {};

assert.deepStrictEqual(ee.eventNames(), []);
assert.strictEqual(ee.eventNames().length, 0);

assert.strictEqual(ee._events.hasOwnProperty, undefined);
assert.strictEqual(ee._events.toString, undefined);
Expand All @@ -16,15 +16,17 @@ ee.on('__proto__', handler);
ee.on('__defineGetter__', handler);
ee.on('toString', handler);

assert.deepStrictEqual(ee.eventNames(), [
'__proto__',
'__defineGetter__',
'toString'
]);

assert.deepStrictEqual(ee.listeners('__proto__'), [handler]);
assert.deepStrictEqual(ee.listeners('__defineGetter__'), [handler]);
assert.deepStrictEqual(ee.listeners('toString'), [handler]);
assert.strictEqual(ee.eventNames().length, 3);
assert.strictEqual(ee.eventNames()[0], '__proto__');
assert.strictEqual(ee.eventNames()[1], '__defineGetter__');
assert.strictEqual(ee.eventNames()[2], 'toString');

assert.strictEqual(ee.listeners('__proto__').length, 1);
assert.strictEqual(ee.listeners('__proto__')[0], handler);
assert.strictEqual(ee.listeners('__defineGetter__').length, 1);
assert.strictEqual(ee.listeners('__defineGetter__')[0], handler);
assert.strictEqual(ee.listeners('toString').length, 1);
assert.strictEqual(ee.listeners('toString')[0], handler);

ee.on('__proto__', common.mustCall(function(val) {
assert.strictEqual(val, 1);
Expand Down

0 comments on commit 5a9eb9b

Please sign in to comment.