Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Josh/nolan localfilesave #303

Open
wants to merge 11 commits into
base: horizon
Choose a base branch
from

Conversation

j3ven7
Copy link

@j3ven7 j3ven7 commented Feb 11, 2019

First merge

dlhsiao and others added 11 commits February 10, 2019 16:14
Changed editor.html to have relative paths to work with web version and app version

Created build_experiment to have electron working files:
-editor.html: change {{GOOGLE_API_KEY}} to empty string

Changed package.json to have start-web and start-app to open either web version or app version from code.pyret.org
Trying to fix the path to the pyret-spin gif
Basic changes for Electron usage
…ing functionality so that when you save it knows to auto-save in the future and when you have opened it continues to autosave the correct file
…y' button -- annotations for code can be found by looking for '(Josh) 2/28/19...'
@schanzer
Copy link

@blerner I'm assuming that

  1. CPO has changed enough in the last half-decade that this PR is no longer usable, and
  2. That with Anchor coming down the pike, this will also soon be moot.

OK to close?

@blerner
Copy link
Member

blerner commented Mar 12, 2024

I've never seen this code before. I don't know what it is intended to do...

@jpolitz
Copy link
Member

jpolitz commented Mar 12, 2024

This was a great idea at the time. It will be superseded by other save-to-localstorage/indexedDB solutions before we can make use of it, though.

@jpolitz jpolitz closed this Mar 12, 2024
@jpolitz
Copy link
Member

jpolitz commented Mar 12, 2024

(This was actually really great work that went a little beyond just local file saving. It was an electron-hosted container for CPO for offline use.)

@blerner
Copy link
Member

blerner commented Mar 12, 2024

Well that does sound cool! 👍

@jpolitz jpolitz reopened this Mar 12, 2024
@jpolitz
Copy link
Member

jpolitz commented Mar 12, 2024

Actually now I'm realizing it still has some good ideas. Looking at the diff is probably useful, and actually only package* conflict. It's kind of orthogonal to what's going on on the page. And since we have BrowserFS presumably we can swap in real node implementations of that API. Not a totally outlandish experiment to try and finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants