avoid extra margins that break layout #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers add margins to <p> elements by default, which breaks the review page layout at least in Firefox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra few pixels of border on
.file-containerand the browser-default margins on.syntax-menu pand the no-modificationsplead to containers that scroll by only a few pixels onbrowseandreview.For instance, in Firefox
browselooks like this to me (note the outer scrollbar and the gap above the inner scrollbar):This change largely fixes those problems.
And while I'm at it, this also makes the review submit button actually hidden on a completed review.
cc @jbclements