Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 3 tier app with scripts #8

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Added 3 tier app with scripts #8

merged 7 commits into from
Jul 19, 2022

Conversation

grkvlt
Copy link
Member

@grkvlt grkvlt commented Dec 1, 2021

Updated scripts for Ubuntu 20. Based on #7 originally.

@grkvlt grkvlt mentioned this pull request Dec 1, 2021
Closed
@grkvlt
Set bundle version tag on blueprint files
4b0b4d9 
Signed-off-by: Andrew Donald Kennedy <[email protected]>
@grkvlt grkvlt requested a review from tbouron December 1, 2021 14:28
tbouron
tbouron reviewed Dec 1, 2021
View reviewed changes
Copy link
Contributor

@tbouron tbouron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grkvlt Looks ok to me, although my bash is a bit rusty. Do you want to wait for another bash-y person to review it or should I merge?

iuliana
iuliana approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@iuliana iuliana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you tested it and the deployed app behaves as expected it is good to merge.

@nakomis
Copy link
Contributor

nakomis commented Jul 18, 2022

LGTM, with minor change which needs merging first: #9

@ahgittin
Merge pull request #9 from nakomis/fix-tomcat-tgz
72e9610 
Fixes label for comcat tgz config
@ahgittin ahgittin merged commit 7a95bfc into master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouron tbouron tbouron left review comments

@iuliana iuliana iuliana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grkvlt @nakomis @tbouron @iuliana @ahgittin