Skip to content

XXX naive yarn lint:fix attempt in tests to illustrate eslint / Prettier tooling issues - DO NOT MERGE #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

XXX naive yarn lint:fix attempt in tests to illustrate eslint / Prettier tooling issues - DO NOT MERGE #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a60582
remove remaining curly exception from .eslintrc.yml
Dec 30, 2020
e98912f
attempt yarn lint:fix, which leads to unexpected token errors
Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,3 @@ rules:
singleQuote: true
spaceBeforeFunctionParen: true
trailingComma: none
# TODO resolve ignored "Standard JS" rule:
curly: 0
11 changes: 5 additions & 6 deletions tests/init-with-example/init-with-example-with-log.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,11 @@ jest.mock('prompts', () => args => {
jest.mock('execa', () => (cmd, args, opts) => {
mockCallSnapshot.push({ execa: [cmd, args, opts] })
if (cmd === 'git') {
if (args[1] === 'user.email')
return Promise.resolve({ stdout: '[email protected]' })
else
return Promise.resolve({
stdout: 'Alice'
})
if (args[1] === 'user.email') {
{ return Promise.resolve({ stdout: '[email protected]' }) } else { return Promise.resolve({
stdout: 'Alice'
})
}
} else {
return Promise.resolve()
}
Expand Down
11 changes: 5 additions & 6 deletions tests/no-example/no-example-module-all.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,11 @@ jest.mock('prompts', () => args => {
jest.mock('execa', () => (cmd, args, opts) => {
mockCallSnapshot.push({ execa: [cmd, args, opts] })
if (cmd === 'git') {
if (args[1] === 'user.email')
return Promise.resolve({ stdout: '[email protected]' })
else
return Promise.resolve({
stdout: 'Alice'
})
if (args[1] === 'user.email') {
{ return Promise.resolve({ stdout: '[email protected]' }) } else { return Promise.resolve({
stdout: 'Alice'
})
}
} else {
return Promise.resolve()
}
Expand Down
11 changes: 5 additions & 6 deletions tests/with-apple-networking/with-apple-networking.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ jest.mock('prompts', () => args => {
jest.mock('execa', () => (cmd, args, opts) => {
mockCallSnapshot.push({ execa: [cmd, args, opts] })
if (cmd === 'git') {
if (args[1] === 'user.email')
return Promise.resolve({ stdout: '[email protected]' })
else
return Promise.resolve({
stdout: 'Alice'
})
if (args[1] === 'user.email') {
{ return Promise.resolve({ stdout: '[email protected]' }) } else { return Promise.resolve({
stdout: 'Alice'
})
}
} else {
return Promise.resolve()
}
Expand Down