feat(loadAsyncData): check window object for server side#23
Closed
evenchange4 wants to merge 1 commit intobrocoders:masterfrom
Closed
feat(loadAsyncData): check window object for server side#23evenchange4 wants to merge 1 commit intobrocoders:masterfrom
evenchange4 wants to merge 1 commit intobrocoders:masterfrom
Conversation
Member
|
@evenchange4 , to be honest, i didn't catch what this PR solves. |
Author
Member
|
@evenchange4, take a look please: there is new interface for @asyncConnect decorator in this version. Now you can use it like: @asyncConnect([
{key: 'lunch', promise: ({params, helpers}) => helpers.client.get('/lunches/' + params.lunchId), group: 'smth'}
])and then in your client.js: const component = (
<Router render={(props) =>
<ReduxAsyncConnect {...props} filter={item => item.group === 'smth'} helpers={{client}} />
} history={browserHistory}>
{getRoutes(store, client)}
</Router>
);and server.js: loadOnServer({...renderProps, store, helpers: {client}}).then(() => {
// ...
}Does it works for you? |
Author
|
okay works for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to solve the PR at #872