Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop gathering instantiation stack manually. #141

Merged
merged 1 commit into from
May 26, 2021
Merged

Stop gathering instantiation stack manually. #141

merged 1 commit into from
May 26, 2021

Commits on May 26, 2021

  1. Stop gathering instantiation stack manually. 

    This was added waaaaaay back in 46e1e23 (2014), long before the newer
`broccoli-plugin` APIs (around Broccoli@1) started creating an
instantiation stack to be used for error handling across the board.

Now that we extend from broccoli-plugin directly, we no longer have to
do this manually. Additionally, the code in broccoli-plugin is authored
such that it avoids touching the `.stack` property unless it is actually
needed (forcing V8 to create the stack is costly).
    @rwjblue
    rwjblue committed May 26, 2021
    Configuration menu
    Copy the full SHA
    f13c490 View commit details
    Browse the repository at this point in the history