-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordering inputFiles #96
Conversation
|
||
var node = concat(node, { | ||
inputFiles: ['**/*.css'], | ||
someMethodName(files) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what to call this yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should actually most likely just be a simple comparator
@@ -43,6 +43,50 @@ The structure of `output.js` will be as follows: | |||
// - footer | |||
``` | |||
|
|||
##### Ordering inputFiles | |||
|
|||
Although when concatenating some types of files, AMD modules for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this words will need rework
} | ||
}); | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain output in example?
* provide match ordered based comparator * allow users to specify there own
27eba45
to
475ddb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
inputFiles: ['foo/*.global.css', 'foo/*.overides.css'] | ||
``` | ||
|
||
One may want, want all global css files to proceed overide css files, while |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo want, want
That really important to keep the order, please merge this asap |
Any chance this will be merged soon? I'd be glad to help but don't know how |
I need to remember why this wasn't merged.. |
@stefanpenner yes this pluggable comparator is exactly what our project need |
@codynguyen makes sense, if you can rebase your PR I'll gladly merge it. It seems good, I think I didn't merge this because I simply didn't circle back. |
cc @chriseppstein