Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering inputFiles #96

Closed
wants to merge 1 commit into from
Closed

Conversation

stefanpenner
Copy link
Collaborator

@stefanpenner stefanpenner commented Nov 20, 2016

  • spike idea in README
  • tests
  • implementation
  • decide on public API method name
  • get someone elses 👀 on this

cc @chriseppstein


var node = concat(node, {
inputFiles: ['**/*.css'],
someMethodName(files) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what to call this yet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should actually most likely just be a simple comparator

@@ -43,6 +43,50 @@ The structure of `output.js` will be as follows:
// - footer
```

##### Ordering inputFiles

Although when concatenating some types of files, AMD modules for example
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this words will need rework

}
});
```

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain output in example?

* provide match ordered based comparator
* allow users to specify there own
@stefanpenner stefanpenner force-pushed the extensible-input-files-sort-order branch from 27eba45 to 475ddb4 Compare November 20, 2016 20:36
@stefanpenner stefanpenner changed the title WIP: Ordering inputFiles Ordering inputFiles Nov 20, 2016
Copy link

@hjdivad hjdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

inputFiles: ['foo/*.global.css', 'foo/*.overides.css']
```

One may want, want all global css files to proceed overide css files, while
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo want, want

@micky2be
Copy link

That really important to keep the order, please merge this asap

@codynguyen
Copy link

Any chance this will be merged soon? I'd be glad to help but don't know how

@stefanpenner
Copy link
Collaborator Author

I need to remember why this wasn't merged..
@codynguyen is your use-case specifically the pluggable comparator?

@codynguyen
Copy link

@stefanpenner yes this pluggable comparator is exactly what our project need

@stefanpenner stefanpenner deleted the extensible-input-files-sort-order branch July 11, 2018 03:41
@stefanpenner
Copy link
Collaborator Author

@codynguyen makes sense, if you can rebase your PR I'll gladly merge it. It seems good, I think I didn't merge this because I simply didn't circle back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants