Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceMap and Simple Strategies have varying support for aboslute paths #119

Open
stefanpenner opened this issue Dec 21, 2017 · 0 comments

Comments

@stefanpenner
Copy link
Collaborator

stefanpenner commented Dec 21, 2017

It appears the during SourceMap concat, we accidentally support absolute paths, but in Simple we do not. We should actually never support absolute paths, and that was merely a mistake.

People run into this, in ember via app.import(someAbsolutePath). And it leads to sadness and confusion, as often they run sourceMaps in dev, but not prod. Resulting in dev including the file and prod not. This sucks.

Two options:

a) We drop support for absolute paths and the rollout plan would be something like:

  1. we warn when we see an absolute path today
  2. we do a major version that changes this warn to an assert
  3. profit

b) We add support uniformly for absolute paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant