Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production builds break with ember-data #332

Closed
jdurand opened this issue Dec 26, 2017 · 2 comments
Closed

Production builds break with ember-data #332

jdurand opened this issue Dec 26, 2017 · 2 comments

Comments

@jdurand
Copy link

jdurand commented Dec 26, 2017

When building a production build that includes ember-data, the build breaks and an error is thrown in the JS console. This happens with any production build once ember-electron & ember-data are packaged together.

Steps to reproduce :

  • git clone https://github.com/jdurand/ember-electron-ember-data-issue.git
  • cd ember-electron-ember-data-issue
  • npm i && ember electron:package -e production
  • open electron-out/ember-electron-issue-darwin-x64/ember-electron-issue.app

In the console, you should get something like Uncaught ReferrenceError: a22500 is not defined

Note that if you either npm uninstall ember-data or package in development ember electron:package -e development this error is not thrown.

Repo reproducing this issue: https://github.com/jdurand/ember-electron-ember-data-issue

@jdurand
Copy link
Author

jdurand commented Dec 26, 2017

@stefanpenner do you think could be linked to broccolijs/broccoli-concat#119?

@jdurand jdurand changed the title Production builds with ember-data are broken Production builds break with ember-data Dec 26, 2017
@jdurand
Copy link
Author

jdurand commented Dec 27, 2017

I'm closing this as this seems to be an issue with Uglify's unused rule (more here: ember-cli/ember-cli#7526 (comment))

@jdurand jdurand closed this as completed Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant