Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional types not recognised #3

Open
Xophmeister opened this issue Mar 6, 2019 · 1 comment
Open

Optional types not recognised #3

Xophmeister opened this issue Mar 6, 2019 · 1 comment

Comments

@Xophmeister
Copy link

When a type is proceeded with a question mark (i.e., an optional value), the highlighting doesn't recognise this as an identifier definition.
Xophmeister added a commit to Xophmeister/vim-wdl that referenced this issue Mar 6, 2019
@Xophmeister
Adds (hacky) support for optional type highlighting
b983fb9 
Resolves broadinstitute#3 but it needs work to avoid false-positives
@Xophmeister Xophmeister mentioned this issue Mar 6, 2019
Open
@Xophmeister
Copy link
Author

Xophmeister commented Mar 6, 2019 •
edited
Loading

Example of a false-positive:

foo? something

foo isn't a valid type, but the question mark will get highlighted as a type and the following symbol (something, in this case) as an identifier regardless. This is my first dabble into Vim syntax definitions; I don't really get why the contains=wdlType bit isn't being honoured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xophmeister