-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze 7 #225
Open
ch-kr
wants to merge
168
commits into
master
Choose a base branch
from
freeze_7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_samples_only is set
…homalt GT hotfix, added VCF start/end position code
jkgoodrich
requested changes
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far. I didn't get through it all because it's very big, but I wanted to put in my current comments because I will be in meetings all day tomorrow and won't get to the rest of the files until Friday.
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
Co-authored-by: jkgoodrich <[email protected]>
jkgoodrich
reviewed
Nov 5, 2021
Co-authored-by: jkgoodrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code updating 455k vcf export for return to UKBB.
Updates:
sample_data_dicts.py
,vcf_data_dicts.py
,data_dict_summaries.md
basics.py
basics.py
get_ukbb_data
to remove new sample IDs with withdrawn consent. Also updatedget_ukbb_data
to exclude samples with undefined batch ifukbb_samples_only
is set:basics.py
utils.py
sanity_checks.py
. NOTE that the code is still expecting an older version of the validity checks from gnomAD methods -- this is the commit that will work (cannot use a more recent commit):d43951086bfea1b80b1bad34b3193f7c031dbc8d
prepare_vcf_data_release.py
prepare_vcf_data_release.py
prepare_vcf_data_release.py
prepare_vcf_data_release.py
manifest.py
vcf_repackage.py
ukbb_header_reformat.sh
ukbb_meta
toukb_meta
:create_meta_ht.py
I think these are all the changes we need to return data -- please let me know if I missed anything!