Skip to content

DDO-2500 fix: argocd cli now prefixes application names with namespace#93

Merged
choover-broad merged 1 commit intomainfrom
ch-DDO-2500-1
Dec 6, 2022
Merged

DDO-2500 fix: argocd cli now prefixes application names with namespace#93
choover-broad merged 1 commit intomainfrom
ch-DDO-2500-1

Conversation

@choover-broad
Copy link
Collaborator

@choover-broad choover-broad commented Dec 6, 2022

argocd app get -o name now lists applications with namespace (<namespace>/<application>) instead of just <application>)

(ref argoproj/argo-cd#9755)

@choover-broad choover-broad requested a review from a team as a code owner December 6, 2022 18:57
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Pushed image: us-central1-docker.pkg.dev/dsp-artifact-registry/thelma/thelma:v1.0.22-d20ca90

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 46.83% // Head: 46.83% // No change to project coverage 👍

Coverage data is based on head (da2dbb3) compared to base (2df630a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   46.83%   46.83%           
=======================================
  Files         255      255           
  Lines        9488     9488           
=======================================
  Hits         4444     4444           
  Misses       4591     4591           
  Partials      453      453           
Flag Coverage Δ
unittests 46.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/thelma/tools/argocd/argocd.go 50.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jack-r-warren jack-r-warren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@choover-broad
Copy link
Collaborator Author

@choover-broad choover-broad merged commit c5b4d3b into main Dec 6, 2022
@choover-broad choover-broad deleted the ch-DDO-2500-1 branch December 6, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants