Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WOR-576] Replace "say" with "echo" to work around git-secrets installation issue #2086

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

cahrens
Copy link
Contributor

@cahrens cahrens commented Oct 20, 2022

Ticket: https://broadworkbench.atlassian.net/browse/WOR-576

git has deleted say. The PR to fix the issue in git-secrets has not been merged. When it is merged, we can update the commit we use to pick up the change and delete this workaround.


PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@cahrens cahrens marked this pull request as ready for review October 20, 2022 15:42
@cahrens cahrens requested review from tlangs, ahaessly and aherbst-broad and removed request for ahaessly October 20, 2022 15:42
@cahrens cahrens changed the title WIP: Try say again WOR-576] Replace "say" with "echo" to work around git secrets installation issue Oct 20, 2022
@cahrens cahrens changed the title WOR-576] Replace "say" with "echo" to work around git secrets installation issue [WOR-576] Replace "say" with "echo" to work around git-secrets installation issue Oct 20, 2022
@cahrens
Copy link
Contributor Author

cahrens commented Oct 20, 2022

ArgoCD again in fiab-start.

11:45:38 3:45PM ERR error executing job error="Command \"ARGOCD_SERVER=ap-argocd.dsp-devops.broadinstitute.org ARGOCD_AUTH_TOKEN=****** argocd --header Proxy-Authorization: Bearer ****** --grpc-web app wait jobmanager-jenkins-swat-72084 --timeout 600 --health\" exited with status 20:\ntime=\"2022-10-20T15:45:38Z\" level=fatal msg=\"application 'jobmanager-jenkins-swat-72084' health state has transitioned from Progressing to Degraded\"\n"

@cahrens
Copy link
Contributor Author

cahrens commented Oct 20, 2022

jenkins retest

1 similar comment
@cahrens
Copy link
Contributor Author

cahrens commented Oct 20, 2022

jenkins retest

@cahrens
Copy link
Contributor Author

cahrens commented Oct 20, 2022

jenkins retest

1 similar comment
@cahrens
Copy link
Contributor Author

cahrens commented Oct 20, 2022

jenkins retest

@cahrens cahrens merged commit 4f40772 into develop Oct 20, 2022
@cahrens cahrens deleted the try-say-again branch October 20, 2022 18:47
@sparr
Copy link

sparr commented Jun 20, 2023

awslabs/git-secrets#221 fixes this upstream and has been merged. You should be able to remove your workaround if you update your pull to a current commit, or to our next release as soon as it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants