Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrintFileDiagnostics for cram, crai and bai. #8577

Merged
merged 1 commit into from
Dec 9, 2023
Merged

PrintFileDiagnostics for cram, crai and bai. #8577

merged 1 commit into from
Dec 9, 2023

Conversation

cmnbroad
Copy link
Collaborator

@cmnbroad cmnbroad commented Nov 7, 2023

Print file diagnostics for cram, crai and bai.

@gatk-bot
Copy link

gatk-bot commented Nov 7, 2023 •
edited
Loading

Github actions tests reported job failures from actions build 6791158196
Failures in the following jobs:

Test Type JDK Job ID Logs
integration 17.0.6+10 6791158196.11 logs
integration 17.0.6+10 6791158196.0 logs

@cmnbroad cmnbroad force-pushed the cn_file_diagnostics branch from 4a1ab89 to 1806eab Compare November 13, 2023 15:11
@cmnbroad cmnbroad marked this pull request as ready for review November 13, 2023 19:36
@cmnbroad cmnbroad force-pushed the cn_file_diagnostics branch from 1806eab to 9d2f8c1 Compare November 13, 2023 19:47
lbergelson
lbergelson approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look through this and it looks good to me. I'm sure I could find some nitpicks if I tried but it has tests and is 0 risk. 👍

@lbergelson lbergelson merged commit 5839cbd into master Dec 9, 2023
20 checks passed
@lbergelson lbergelson deleted the cn_file_diagnostics branch December 9, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbergelson lbergelson lbergelson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmnbroad @gatk-bot @lbergelson