Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --min-fragment-length argument to FragmentLengthReadFilter #5886

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

droazen
Copy link
Collaborator

@droazen droazen commented Apr 16, 2019

Also improved the existing tests for FragmentLengthReadFilter

Resolves #5884

Also improved the existing tests for FragmentLengthReadFilter

Resolves #5884
@droazen
Copy link
Collaborator Author

droazen commented Apr 16, 2019

@samuelklee or @mwalker174 please review, as this feature originated as a request for the CNV pipeline (#5884)

Copy link
Contributor

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @droazen - this looks good to me.

@codecov-io
Copy link

codecov-io commented Apr 16, 2019

Codecov Report

Merging #5886 into master will increase coverage by 0.009%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##              master     #5886       +/-   ##
===============================================
+ Coverage     86.823%   86.833%   +0.009%     
- Complexity     32291     32297        +6     
===============================================
  Files           1991      1991               
  Lines         149120    149202       +82     
  Branches       16477     16480        +3     
===============================================
+ Hits          129471    129556       +85     
+ Misses         13636     13633        -3     
  Partials        6013      6013
Impacted Files Coverage Δ Complexity Δ
...lbender/cmdline/ReadFilterArgumentDefinitions.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ender/engine/filters/FragmentLengthReadFilter.java 100% <100%> (ø) 5 <0> (+1) ⬆️
...nder/engine/filters/ReadFilterLibraryUnitTest.java 100% <100%> (ø) 62 <3> (+3) ⬆️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (+30%) 3% <0%> (+2%) ⬆️

@droazen droazen merged commit 86a71a1 into master Apr 17, 2019
@droazen droazen deleted the dr_minimum_fragment_length_filter branch April 17, 2019 14:04
@samuelklee
Copy link
Contributor

Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to restrict fragment length for calling CNVs
4 participants