use IntelDeflaterFactory from the GKL #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,6 +129,13 @@ public Object instanceMainPostParseArgs() { | |||
| System.setProperty("java.io.tmpdir", f.getAbsolutePath()); // in loop so that last one takes effect | |||
| } | |||
|
|
|||
| //Set defaults (note: setting them here means they are not controllable by the user) | |||
| BlockCompressedOutputStream.setDefaultDeflaterFactory(new IntelDeflaterFactory()); | |||
There was a problem hiding this comment.
Add a command-line arg to CommandLineProgram that allows the user to opt-out of using the IntelDeflater
|
i'll grab it |
|
note: This PR does not reinstate the IntelDeflater for Spark. It's now a bit tricky because you need to call |
akiezun
force-pushed
the
ak_use_intelDeflaterFactory
branch
from
1222cd4
to
0aa6f36
Compare
|
GKL 0.1.1 release in Maven Central resolves Intel-HLS/GKL#8 (not the Spark issue) |
akiezun
force-pushed
the
ak_use_intelDeflaterFactory
branch
from
0aa6f36
to
7b821e4
Compare
|
thanks @gspowley - using 0.1.1 now and the issue is fixed |
This was referenced Jul 1, 2016
This was referenced Jul 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1903
also updated the system properties in build.gradle and gatk-launch