Skip to content

Conversation

cornhundred
Copy link
Collaborator

No description provided.

@cornhundred cornhundred requested a review from Copilot October 8, 2025 20:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances visualization performance and configurability by adding controls for tile calculation and point cloud radius sizing. The changes prevent unnecessary tile calculations for point cloud technology and allow configurable radius settings.

  • Added configurable point cloud radius parameter with default value of 5
  • Implemented conditional tile calculation logic to skip processing for point-cloud technology
  • Added max_tiles_to_view parameter to control tile loading thresholds

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/celldega/viz/widget.py Added max_tiles_to_view and point_cloud_radius traitlets parameters
pyproject.toml Version bump from 0.14.0a2 to 0.14.0a3
package.json Version bump from 0.14.0-alpha.2 to 0.14.0-alpha.3
js/widget.js Added point_cloud_radius parameter extraction and passing
js/viz/landscape_ist.js Added point_cloud_radius parameter and initialization in viz_state
js/ui/sliders.js Updated cell slider calculation to use configurable radius
js/deck-gl/layers/cell_layer.js Updated pointSize to use configurable radius value
js/deck-gl/core/calc_viewport.js Added conditional logic to skip tile calculations for point-cloud technology

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

);

} else {
tiles_in_view = []
Copy link

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon at the end of the statement. JavaScript statements should end with semicolons for consistency and to avoid potential issues.

Suggested change
tiles_in_view = []
tiles_in_view = [];

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant